refactor(input): migrate to signals #475
Open
+20
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrobin
approved these changes
Nov 13, 2024
goetzrobin
reviewed
Nov 14, 2024
goetzrobin
approved these changes
Nov 14, 2024
|
@marcjulian the chromatic build failed with a type error for storybook. can you check that? |
marcjulian
commented
Nov 15, 2024
| @@ -45,7 +45,7 @@ type InputVariants = VariantProps<typeof inputVariants>; | |||
| export class HlmInputDirective implements BrnFormFieldControl, DoCheck { | |||
| public readonly size = input<InputVariants['size']>('default'); | |||
|
|
|||
| public readonly error = signal<InputVariants['error']>('auto'); | |||
| public readonly error = input<InputVariants['error']>('auto'); | |||
There was a problem hiding this comment.
@goetzrobin should be fixed now. Somehow I forgot to change error to input which caused the type error in storybook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #421
What is the new behavior?
Does this PR introduce a breaking change?
Other information