Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-853: Give VA scale factor a reasonable default #396

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stscieisenhamer
Copy link
Collaborator

WIP RCAL-853

Main PR: PR#1354

This PR gives the velocity_aberration.scale_facter meta a default working value of 1.0

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • start a romancal regression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@stscieisenhamer stscieisenhamer changed the title Give VA scale factor a reasonable default RCAL-853: Give VA scale factor a reasonable default Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (087a60d) to head (759ea7d).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   97.56%   97.75%   +0.19%     
==========================================
  Files          30       37       +7     
  Lines        2788     3380     +592     
==========================================
+ Hits         2720     3304     +584     
- Misses         68       76       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but can you run regtests? I think those all basically pass through the metadata from the L1s and so probably aren't sensitive to this, but if they are we should know about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants