Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: improve margin in expansion panels in plugins #2540

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Oct 27, 2023

Description

This pull request removes the negative margin for expansion panels within plugins.

Before:

Screen Shot 2023-10-27 at 3 17 07 PM

After:

Screen Shot 2023-10-27 at 3 16 47 PM

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added UI/UX😍 no-changelog-entry-needed changelog bot directive labels Oct 27, 2023
@kecnry kecnry mentioned this pull request Oct 27, 2023
9 tasks
@github-actions github-actions bot added cubeviz embed Regarding issues with front-end embedding specviz2d labels Oct 27, 2023
@kecnry

This comment was marked as resolved.

@pllim pllim added this to the 3.8 milestone Oct 27, 2023
to prevent the negative margin imposed on the plugin content itself
@kecnry kecnry marked this pull request as ready for review October 27, 2023 19:18
@pllim pllim removed their request for review October 27, 2023 19:19
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in both Imviz and Cubeviz. Thank you!

@kecnry kecnry added the trivial Only needs one approval instead of two label Oct 27, 2023
@kecnry kecnry merged commit 4178d8a into spacetelescope:main Oct 27, 2023
18 of 19 checks passed
@kecnry kecnry deleted the expansion-panel-margin branch October 27, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz embed Regarding issues with front-end embedding no-changelog-entry-needed changelog bot directive specviz2d trivial Only needs one approval instead of two UI/UX😍
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants