Update everything to SCIP #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From looking at the recent changes to scip-java when you call index on a project it expects the `sourcegraphScip` task to be there. This pr makes the changes to align the task and setting names.
chore: bump sbt to 1.6.2 and move to unified slash syntax
|
Hey, I created a PR to revert the slash syntax to support sbt 0.13 #54 could you take a look at it? |
tanishiking
reviewed
Jun 23, 2022
| file: dump.lsif | ||
| - name: cs launch scip-java | ||
| run: | | ||
| cs launch com.sourcegraph:lsif-java_2.13:latest.stable -M com.sourcegraph.lsif_java.LsifJava -- index |
There was a problem hiding this comment.
Suggested change
| cs launch com.sourcegraph:lsif-java_2.13:latest.stable -M com.sourcegraph.lsif_java.LsifJava -- index | |
| cs launch com.sourcegraph:scip-java_2.13:latest.stable -M com.sourcegraph.scip_java.ScipJava -- index |
I confirmed it works in my local environment
ckipp01
added a commit
to ckipp01/sbt-sourcegraph
that referenced
this pull request
Aug 26, 2022
This aligns CI a bit better with how it's being done in scip-java. It also ensures actions/checkout is up to date and that the sourcegraph upload is the newly recommended way of using the yarn installed `src`. Supercedes sourcegraph#36 Relates to some CI changes in sourcegraph#51 Supercedes sourcegraph#56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
See the CI go green.