-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor scrabble module #276
Conversation
This allows for single source of truth, and also improves editor responsiveness (cutting down tokenization time, etc.). The correctness is guaranteed by the introduction of snapshots in tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've generated the snapshots once before the refactor (refer to commit history) and can confirm that the refactor does not change the snapshots.
@martin-henz can I check what exactly qualifies for |
I remember playing with the scrabble module in preparation for the PA last semester. There was a concern that the full dataset would be too large for some student's computers, so I came up with scrabble_words_tiny. I think I sampled the full set at intervals of 100:
[We ended up not using the |
Ok, I've used This PR is ready now, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
Generates scrabble letters using
.map
on words to:Also generates the tiny dataset using
.filter
every 100 words.The correctness is guaranteed by the introduction of additional tests, ensuring they stay the (snapshot-checking).
Type of change
Please delete options that are not relevant.