Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1718 stepper built in function errors not caught and crashing the frontend #1719

Conversation

hanscau
Copy link
Contributor

@hanscau hanscau commented Sep 9, 2024

Description

Built In Function's Error handling throws Errors that the stepper cannot handle. Changed the errors to SourceErrors instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvements

How to test

Test exists, wrong expected answers

Note

BuiltInFunctionError changed to only take in explanation without node to handle all built in function error. These errors without a node should be handled by the parser instead.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10778076151

Details

  • 8 of 15 (53.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 81.543%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stepper/lib.ts 4 11 36.36%
Totals Coverage Status
Change from base Build 10777866826: 0.02%
Covered Lines: 10928
Relevant Lines: 13033

💛 - Coveralls

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martin-henz martin-henz merged commit f443ccc into master Sep 10, 2024
4 checks passed
@martin-henz martin-henz deleted the 1718-stepper-built-in-function-errors-not-caught-and-crashing-the-frontend branch September 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper: Built-In function errors not caught and crashing the frontend
3 participants