Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gpu.js to 2.16.0 #1464

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Bump gpu.js to 2.16.0 #1464

merged 1 commit into from
Aug 12, 2023

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Aug 11, 2023

This bumps the transitive dependency gl from v4 to v5.

May or may not resolve #1417 (but good to bump anyway).

Context: our grader resolves this by using selective dependency resolution (as it can't edit js-slang directly). This may also remove the need for such overrides.

Also bumps the transitive dependency gl from v4 to v5.
@RichDom2185 RichDom2185 self-assigned this Aug 11, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5832561138

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.893%

Totals Coverage Status
Change from base Build 5829225796: 0.0%
Covered Lines: 10735
Relevant Lines: 12523

💛 - Coveralls

@RichDom2185
Copy link
Member Author

CI passes so should be okay to bump?

@RichDom2185 RichDom2185 enabled auto-merge (squash) August 11, 2023 12:38
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope it works.

@RichDom2185 RichDom2185 merged commit 1d99116 into master Aug 12, 2023
1 check passed
@RichDom2185 RichDom2185 deleted the bump-gpu-js branch August 12, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot npm install due to gpu.js/angle not compiling
3 participants