Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stepper: infinite loop in findMain #1460

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Fix stepper: infinite loop in findMain #1460

merged 1 commit into from
Aug 7, 2023

Conversation

Ziwen510
Copy link
Contributor

@Ziwen510 Ziwen510 commented Aug 7, 2023

This pull request resolves the issue of breakdowns while executing substitutions in the stepper.

@Ziwen510 Ziwen510 linked an issue Aug 7, 2023 that may be closed by this pull request
Stepper: breaks when there are declarations between a recursive function's declaration and its application #1433
Closed
@Ziwen510 Ziwen510 self-assigned this Aug 7, 2023
@Ziwen510 Ziwen510 added the Bug Something isn't working label Aug 7, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5781379635

  • 12 of 16 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 82.888%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stepper/stepper.ts 12 16 75.0%
Totals Coverage Status
Change from base Build 5726679425: -0.001%
Covered Lines: 10735
Relevant Lines: 12525
💛 - Coveralls

martin-henz
martin-henz approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as discussed.

@martin-henz martin-henz merged commit 45a2c61 into master Aug 7, 2023
1 check passed
@martin-henz martin-henz deleted the fix-stepper-infinite branch August 7, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

Assignees

@Ziwen510 Ziwen510

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stepper: breaks when there are declarations between a recursive function's declaration and its application
3 participants
@Ziwen510 @coveralls @martin-henz