-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Publish Grading Feature #2546
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new grading state 'Published' - Add UI component to grading dashboard to enable publishing feature - Update sagas to accept new backend boolean and allow publish requests - Update frontend logic for computing grading status - Add new notification - Update relavant badges and misc files for new field and grading state
# Conflicts: # src/commons/application/actions/SessionActions.ts # src/commons/sagas/BackendSaga.ts - Remove no longer relevant tokens in publish grading requests
@emptygx can we fix the failing tests? |
Hey so sorry but I am not too sure how to go about fixing them, could I have some guidance on this? Thank you! |
6 tasks
Superseded by #2856. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(closes #2522)
Currently, the grading states design and business logic cause ambiguity with resubmission of assessments being assumed to be graded immediately, and with grades being displayed when they should not.
This feature aims to solve this issue by introducing a new grading state
published
and a new backend booleanis_grading_published
, allowing explicit publishing of student's grades on the frontend and preventing the fetching of grades if they have yet to be published, hence creating a better logic flow.This pull request contains changes to be made to the frontend to enable this new feature.
Type of change
How to test
(Import your own assessment XML files for testing if possible)
Checklist