Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary trips to the DB #1189

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Remove unnecessary trips to the DB #1189

merged 10 commits into from
Sep 20, 2024

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Sep 20, 2024 •
edited
Loading

Fixes a regression introduced in #1097

@RichDom2185 RichDom2185 self-assigned this Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Coverage Status

coverage: 94.326% (-0.002%) from 94.328%
when pulling 35d3fd2 on remove-unnecessary-db-trips
into 6d33c09 on master.

@RichDom2185 RichDom2185 enabled auto-merge (squash) September 20, 2024 15:44
@RichDom2185 RichDom2185 enabled auto-merge (squash) September 20, 2024 15:45
GabrielCWT
GabrielCWT approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@GabrielCWT GabrielCWT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets get this deployed quickly.

@RichDom2185 RichDom2185 merged commit b02b43c into master Sep 20, 2024
2 checks passed
@RichDom2185 RichDom2185 deleted the remove-unnecessary-db-trips branch September 20, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielCWT GabrielCWT GabrielCWT approved these changes

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichDom2185 @coveralls @GabrielCWT