sam info includes fees #253
Conversation
🦋 Changeset detectedLatest commit: 56ad51b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vigneshka
force-pushed
the
vigneshka/sam-info-with-fees
branch
from
0f6e802
to
5f3fe55
Compare
| @@ -112,8 +114,7 @@ export async function SamBuy( | |||
| { editionAddress }: SamEditionAddress, | |||
| { | |||
| quantity, | |||
|
|
|||
There was a problem hiding this comment.
in our regular non-sam mint, we pass in sale schedule and quantity, and it calculates totalValue
here, price is confusing because you may think it means price per nft, since quantity is also an arg
clarifying it is maxTotalValue (calculated with the flat tx fee, and not have the percent platform fee for new sam)
vigneshka
requested review from
PabloSzx and
saihaj
and removed request for
PabloSzx
| const samContract = SAM__factory.connect(samAddress, providerOrSigner) | ||
|
|
||
| const [info, platformFeeBPS] = await Promise.all([ | ||
| samContract.samInfo(editionAddress), |
There was a problem hiding this comment.
with viem refactor, this will be easier to consolidate into 1 network request
currently, this read function is not used in our FE, we index the data in our BE when an event comes in and serve from our api in SamConfig
vigneshka
force-pushed
the
vigneshka/sam-info-with-fees
branch
from
a23dff9
to
5f3fe55
Compare
support sam v1.1
create a consistent returned type for the data
renames arg in sam buy for clarity