Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Remove URL shortening #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[refactor] Remove URL shortening #24

wants to merge 3 commits into from

Conversation

6r1d
Copy link
Contributor

@6r1d 6r1d commented Nov 22, 2022

Demonstrates what happens if we remove shortening on the Latest Transactions.
I believe the alternative solution with #23 is better.

Screenshot_2022-11-22_08-03-37

@6r1d 6r1d mentioned this pull request Nov 22, 2022
Merged
0x009922
0x009922 reviewed Dec 1, 2022
View reviewed changes
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that with an increased line-height text wrapping for hash will look much better. Consider asking a designer about which line-height exactly is suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@6r1d @0x009922