Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci fixes develop to staging #1203

Open
wants to merge 20 commits into
base: staging
Choose a base branch
from

Merge pull request #1210 from soramitsu/MWR-951

812c6ed
Select commit
Loading
Failed to load commit list.
Open

ci fixes develop to staging #1203

Merge pull request #1210 from soramitsu/MWR-951
812c6ed
Select commit
Loading
Failed to load commit list.
Soramitsu-Sonar-PR-decoration / fearless-android Sonarqube Results failed Oct 9, 2024 in 3m 34s

Quality Gate failed

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)
  • 4 New Issues (is greater than 0)

Analysis Details

4 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 4 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.10% Estimated after merge)

Project ID: fearless:fearless-android

View in SonarQube

Annotations

Check warning on line 40 in feature-wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/data/repository/PricesSyncService.kt

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / fearless-android Sonarqube Results

feature-wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/data/repository/PricesSyncService.kt#L40

Avoid hardcoded dispatchers.

Check warning on line 167 in feature-wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/di/WalletFeatureModule.kt

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / fearless-android Sonarqube Results

feature-wallet-impl/src/main/java/jp/co/soramitsu/wallet/impl/di/WalletFeatureModule.kt#L167

This function has 17 parameters, which is greater than the 7 authorized.

Check failure on line 44 in runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/ChainSyncService.kt

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / fearless-android Sonarqube Results

runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/ChainSyncService.kt#L44

Refactor this method to reduce its Cognitive Complexity from 33 to the 15 allowed.

Check warning on line 18 in runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/RemoteAssetsSyncService.kt

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / fearless-android Sonarqube Results

runtime/src/main/java/jp/co/soramitsu/runtime/multiNetwork/chain/RemoteAssetsSyncService.kt#L18

Make this interface functional or replace it with a function type.