Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] manifest 및 og tag link 수정 #419

Merged
merged 2 commits into from
Aug 17, 2024
Merged

[Fix] manifest 및 og tag link 수정 #419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00f0651
fix: manifest 파일명
lydiacho Aug 17, 2024
eeaf951
fix: og tag link full url로 수정
lydiacho Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,26 +18,26 @@
<meta property="og:type" content="website" />
<meta property="og:locale" content="ko_KR" />

<link rel="manifest" href="/makersManifest.webmanifest" />
<link rel="manifest" href="https://recruiting.sopt.org/manifest.webmanifest" />

<link rel="icon" href="/makersFavicon.ico" sizes="32x32" />
<link rel="icon" href="/makersIcon.svg" type="image/svg+xml" />
<link rel="apple-touch-icon" href="/makers-touch-icon.png" />
<link rel="icon" href="https://recruiting.sopt.org/makersFavicon.ico" sizes="32x32" />
<link rel="icon" href="https://recruiting.sopt.org/makersIcon.svg" type="image/svg+xml" />
<link rel="apple-touch-icon" href="https://recruiting.sopt.org/makers-touch-icon.png" />

<meta property="og:title" content="SOPT makers 모집 지원하기" />
<meta property="og:description" content="SOPT makers의 신입 기수 모집페이지입니다." />
<meta property="og:site_name" content="SOPT makers 리크루팅" />
<meta property="og:url" content="https://recruiting.sopt.org" />

<meta property="og:image" content="/makersOg.png" />
<meta property="og:image" content="https://recruiting.sopt.org/makersOg.png" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉스 아니에요!

public에 있는건 상대경로로 설정해도 정상작동합니다!!

현재 ogImage가 보여지고 있지 않은 이유는 makersOg.png 파일 이름이 maekrsOg로 오타가 나서 그래요ㅜㅜㅜ
다른 부분도 다 full url 말고 / 이후 부분만 입력해도 다 정상 작동합니다 :)

근데 사실 위와 같이 표현해도 문제될 건 없으니 이대로 가도 좋습니다~~

고생하셨습니다ㅜ!!

<meta property="og:image:alt" content="SOPT makers 리크루팅" />
<meta property="og:image:width" content="800" />
<meta property="og:image:height" content="400" />

<meta property="twitter:card" content="website" />
<meta name="twitter:title" content="SOPT makers 모집 지원하기" />
<meta name="twitter:description" content="SOPT makers의 신입 기수 모집페이지입니다." />
<meta name="twitter:image" content="/makersOg.png" />
<meta name="twitter:image" content="https://recruiting.sopt.org/makersOg.png" />
<meta property="twitter:image:alt" content="SOPT makers 리크루팅" />
<meta property="twitter:site" content="https://recruiting.sopt.org" />

Expand Down