Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 전체화면 권장 제거 #409

Merged
merged 2 commits into from
Aug 17, 2024
Merged

[Fix] 전체화면 권장 제거 #409

merged 2 commits into from
Aug 17, 2024

Conversation

eonseok-jeon
Copy link
Member

Related Issue : Closes #408


🧑‍🎤 Summary

  • 지원서 다시보기 누를 시 전체 페이지 이용해달라는 alert 뜨는 이슈 해결

🧑‍🎤 Comment

다시보기도 이제 반응형 지원하니까 해당 alert는 없어도 될 거 같아 제거했어요!

App.tsx에 mobile 관련 regex가 주석으로 남아있어서
MyPage에는 해당 코드 제거해줬어요!

@eonseok-jeon eonseok-jeon linked an issue Aug 17, 2024 that may be closed by this pull request
Copy link

height bot commented Aug 17, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@lydiacho lydiacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 !

@eonseok-jeon eonseok-jeon merged commit dbd0713 into develop Aug 17, 2024
@eonseok-jeon eonseok-jeon deleted the fix/#408_full-alert branch August 17, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 전체화면 권장 제거
2 participants