Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 솝탬프 닉네임 설정 오류 수정 #422

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Conversation

kseysh
Copy link
Member

@kseysh kseysh commented Oct 15, 2024

📝 PR Summary

솝탬프 닉네임 생성에 오류가 있는 부분을 수정하였습니다.

🌴 Works

  • PlaygroundPart에서 운영진들도 정확한 파트를 받을 수 있도록 했습니다.
  • 기존 soptampNickname이라는 실제 사용과 혼란이 있을 가능성이 있는 이름을 shortedPartName으로 변경하였습니다.
  • 현재 기수만 soptampUser를 upsert할 수 있도록 하였습니다. (불필요한 soptamp user 생성 방지)

🌱 Related Issue

closed #421

🌵 PR 참고사항

  • postman 테스트 완료했습니다.
  • 이렇다면 회장, 부회장, 총무, 운팀장, 미팀장, 메팀장은 솝탬프에 참여하더라도 파트별 랭킹에 관여가 불가합니다 (원래 불가능했어요)
  • "~~파트장"이 나을까요 "~~팟장"이 나을까요?

@kseysh kseysh added 🐞 Bug 에러 확인 🛠️ BugFix 버그 해결 labels Oct 15, 2024
@kseysh kseysh self-assigned this Oct 15, 2024
Copy link

height bot commented Oct 15, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Contributor

@rlarlgnszx rlarlgnszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~~ 수고하셨습니다~!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p3:
디테일한 상세처리 좋은것 같습니다!

@kseysh kseysh merged commit bd9afe7 into dev Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug 에러 확인 🛠️ BugFix 버그 해결 size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX] 로그인시에 닉네임 변경되는 로직 오류
2 participants