Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 엔티티에 Not Null 제약조건 추가 #402

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

[REFACTOR] 엔티티에 Not Null 제약조건 추가 #402

wants to merge 12 commits into from

Conversation

kseysh
Copy link
Member

@kseysh kseysh commented Oct 8, 2024

📝 PR Summary

엔티티에 Not Null 제약조건을 추가하였습니다.

🌴 Works

  • 엔티티에 Not Null 제약조건을 추가

🌱 Related Issue

closed #401

🌵 PR 참고사항

  • dev와 prod에 ddl로 not null 제약 조건 추가 및 확인 이후 머지할 예정입니다.

@kseysh
[refactor] AppService에서 BaseEntity 상속해제 (#399)
64604a5
@kseysh
[refactor] FortuneCard에서 NotNull 제약조건 추가 (#399)
19c10b7
@kseysh
[refactor] MainDescription에서 BaseEntity 상속해제 (#401)
68d77b3
@kseysh
[refactor] Mission에서 NotNull 제약조건 추가 및 default value 추가 (#401)
62fe08d
@kseysh
[refactor] Mission에서 NotNull 제약조건 추가 및 default value 추가 (#401)
3b6456a
@kseysh
[refactor] PokeHistory에서 NotNull 제약조건 추가 및 default value 추가 (#401)
f34cbb7
@kseysh
[refactor] RecommendedUserIds에서 NotNull 제약조건 추가 (#401)
60f5bc6
@kseysh
[refactor] SoptampUser에서 NotNull 제약조건 추가 (#401)
f62ae95
@kseysh
[refactor] Stamp에서 NotNull 제약조건 추가 (#401)
4d7830c
@kseysh
[refactor] User에서 NotNull 제약조건 추가 (#401)
d7b76e3
@kseysh
[fix] AppService의 created_at을 사용하는 로직이 있어 수정 (#401)
3bf37d5
@kseysh
[fix] primitive boolean과 lombok의 Getter의 호환성 문제로 수정 (#401)
3583c39
@kseysh kseysh added 🔨 Refactor 코드 개선 ☁️ DB 데이터베이스 관련 labels Oct 8, 2024
@kseysh kseysh requested a review from rlarlgnszx October 8, 2024 17:54
@kseysh kseysh self-assigned this Oct 8, 2024
@height Height
Copy link

height bot commented Oct 8, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

rlarlgnszx
rlarlgnszx approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@rlarlgnszx rlarlgnszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제약조건에 대해서 많이 고민해보신것 같습니다!
현재는 DB 제약조건에 대해서 제약조건이 걸려있는데 저도 얼마전에
제약 조건에 대해서 많이 얘기듣고 알아보다 좋은 글이 있어서 첨부합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlarlgnszx rlarlgnszx rlarlgnszx approved these changes

Assignees

@kseysh kseysh

Labels
☁️ DB 데이터베이스 관련 🔨 Refactor 코드 개선 size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Entity에 NOT NULL 제약조건 추가
2 participants
@kseysh @rlarlgnszx