Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] fortuneId -> fortuneWordId로 네이밍 변경 및 자잘한 리팩토링 #393

Merged
merged 4 commits into from
Oct 8, 2024
Merged

[REFACTOR] fortuneId -> fortuneWordId로 네이밍 변경 및 자잘한 리팩토링 #393

merged 4 commits into from
Oct 8, 2024

Conversation

kseysh
Copy link
Member

@kseysh kseysh commented Oct 6, 2024

📝 PR Summary

fortuneId -> fortuneWordId로 네이밍 변경 및 자잘한 리팩토링

🌴 Works

  • fortuneId -> fortuneWordId로 네이밍 변경
  • 자잘한 리팩토링

🌱 Related Issue

closed #392

@kseysh kseysh added 🧹 Chore 기능 수정이 아닌 잡일들 🔨 Refactor 코드 개선 labels Oct 6, 2024
@kseysh kseysh requested a review from rlarlgnszx October 6, 2024 16:39
@kseysh kseysh self-assigned this Oct 6, 2024
@height Height
Copy link

height bot commented Oct 6, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

rlarlgnszx
rlarlgnszx approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@rlarlgnszx rlarlgnszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~ 수고하셨습니다!

@kseysh
Copy link
Member Author

kseysh commented Oct 7, 2024

머지 전 ddl 변경하기

@kseysh kseysh merged commit 0604766 into dev Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlarlgnszx rlarlgnszx rlarlgnszx approved these changes

Assignees

@kseysh kseysh

Labels
🧹 Chore 기능 수정이 아닌 잡일들 🔨 Refactor 코드 개선 size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] 혼란을 야기하는 fortuneId 네이밍 변경
2 participants
@kseysh @rlarlgnszx