Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli.plugins: include version number in sopel-plugins show #2638

Merged
merged 1 commit into from
Oct 26, 2024
Merged

cli.plugins: include version number in sopel-plugins show #2638

merged 1 commit into from
Oct 26, 2024

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 21, 2024

Description

There are definitely more improvements I'd like to make in the sopel-plugins CLI (e.g. #2459), but this one is simple enough to ship with a patch release.

Several times, I've wished that it was possible to see which version of a plugin Sopel sees without starting the bot to use the .version pluginname command on IRC.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added this to the 8.0.1 milestone Oct 21, 2024
@dgw dgw requested a review from a team October 21, 2024 18:32
Exirel
Exirel approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Indeed, I think it might have been an oversight when the method to get a plugin's version was added.

@dgw dgw merged commit 2e8de02 into master Oct 26, 2024
17 checks passed
@dgw dgw deleted the plugins-show-version branch October 26, 2024 00:45
dgw added a commit that referenced this pull request Oct 26, 2024
@dgw
Backport version number in sopel-plugins show from #2638 to 8.0.1
645e62a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Core/Plugin Handling Low Priority Tweak
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel