Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.15.x] Bump envoy-gloo, re-enabling support for REST EDS #9048

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

ben-taussig-solo
Copy link
Contributor

@ben-taussig-solo ben-taussig-solo commented Jan 9, 2024

Description

  • Bump envoy-gloo to v1.26.5-patch2
  • This bump contains updates to envoy-gloo's extensions_build_config.bzl which re-enable support for REST EDS, which was deprecated in upstream envoy v1.26
  • As discussed in Gloo fails after upgrade from 1.14.27 to 1.15.x #8968, users of 1.15.x (which depends on envoy-gloo v1.26.x) were previously unable to configure REST EDS
    • Please note that we currently do not recommend users to enable REST EDS, as it is significantly less performant and does not offer meaningful benefits as compared to the default GRPC XDS/EDS strategy

Testing steps

  • I urge any reviewers to manually verify this behavior before approving this PR

Part 1: Validate that REST EDS is currently broken

  1. Create a kind cluster:
    • kind create cluster --name kind
  2. Install Gloo Edge 1.15.x with REST EDS enabled
    • helm install gloo gloo/gloo -n gloo-system --create-namespace --devel --version 1.15.18 --set settings.enableRestEds=true
  3. Inspect the gateway-proxy deployment logs to confirm that errors are present
    • kubectl logs -n gloo-system deployment/gateway-proxy | grep "Didn't find a registered config subscription factory"
    • You should see many results

Part 2: Validate that the new changes resolve the issue

  1. Build the envoy-gloo wrapper docker image and push it to the kind cluster, updating the gateway-proxy deployment to use the new image
    • VERSION=1.15.18-rest-eds-test make kind-reload-gloo-envoy-wrapper
  2. Inspect the gateway-proxy deployment logs to confirm that errors are no longer present
    • kubectl logs -n gloo-system deployment/gateway-proxy | grep "Didn't find a registered config subscription factory"
    • You should see no results

@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jan 9, 2024
@ben-taussig-solo ben-taussig-solo enabled auto-merge (squash) January 9, 2024 19:46
@ben-taussig-solo ben-taussig-solo merged commit 90cac34 into v1.15.x Jan 10, 2024
12 checks passed
@ben-taussig-solo ben-taussig-solo deleted the rest-eds-upgrade-failure-envoy-bump branch January 10, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants