Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy 1.26 bump (includes inja bump) #8440

Merged
merged 39 commits into from
Jul 14, 2023
Merged

Conversation

jbohanon
Copy link
Contributor

@jbohanon jbohanon commented Jul 5, 2023

Description

Bump envoy-gloo-ee to 1.26 version. The investigation around this change can be found in this doc. This bump will also include latest version of Inja.

This is really noisy due to protoc-gen-go dep bump, but the real changes are in

  • Makefile
  • docs/content/guides/traffic_management/request_processing/transformations/_index.md
  • go.mod
  • projects/gloo/api/external/envoy/config/core/v3/proxy_protocol.proto
  • projects/gloo/api/external/envoy/extensions/transformation/transformation.proto (comment only)
  • projects/gloo/pkg/plugins/dynamic_forward_proxy/plugin.go
  • projects/gloo/pkg/plugins/hcm/testing/expected_hcm_fields.json
  • test/kube2e/gateway/gateway_test.go

Checklist:

  • I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/main/changelogutils) which references the issue that is resolved.
  • If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • I followed guidelines laid out in the Gloo Edge contribution guide
  • I opened a draft PR or added the work in progress label if my PR is not ready for review
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@jbohanon jbohanon requested a review from a team as a code owner July 5, 2023 15:17
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jul 5, 2023
@solo-changelog-bot
Copy link

Issues linked to changelog:
#8177

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Visit the preview URL for this PR (updated for commit 8c09ed7):

https://gloo-edge--pr8440-envoy-gloo-bump-for-pf3tvz0t.web.app

(expires Fri, 21 Jul 2023 18:46:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@nfuden
Copy link
Contributor

nfuden commented Jul 5, 2023

Can we test this with 1.25?

@jbohanon jbohanon added the work in progress signals bulldozer to keep pr open (don't auto-merge) label Jul 6, 2023
@jbohanon jbohanon changed the title Envoy gloo bump for inja [DNM] Envoy gloo bump for inja Jul 6, 2023
@jbohanon jbohanon changed the title [DNM] Envoy gloo bump for inja [DNM] Envoy 1.26 bump (includes inja bump) Jul 14, 2023
@nfuden nfuden changed the title [DNM] Envoy 1.26 bump (includes inja bump) Envoy 1.26 bump (includes inja bump) Jul 14, 2023
@jbohanon jbohanon removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Jul 14, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@solo-io/solo-docs sorry about all of the noise in this file. The real changes are on L172, L174, L385, L388

Copy link
Contributor

@nfuden nfuden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think next time we do a seperate pr for the protobuf bump to remove it from functional code XD

@soloio-bulldozer soloio-bulldozer bot merged commit 2fe0de3 into main Jul 14, 2023
12 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the envoy-gloo-bump-for-inja branch July 14, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants