Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.26] Update extensions build config #298

Merged

Conversation

ben-taussig-solo
Copy link
Contributor

Description

  • Update extensions_build_config.bzl to pull in features which are not
    enabled by default.
  • Introduces a script to check that the extensions_build_config.bzl is up to date with the current envoy version.
    • This script is run as a github action on every PR to ensure that the extensions_build_config.bzl is up to date with the current envoy version.

…ns (#292)

* update extensions_build_config.bzl

* add changelog entry

* uncomment new extensions

* add load balancing policies to extensions_build_config.bzl

* add script to compare envoy_gloo extensions_build_config with usptream

* add new script to cloudbuild.yaml

* move script to github action

* updates to script

* update preprocessing in script

* keep extensions_build_config.bzl up to date

* reintroduce accidentally removed part of script

* update changelog entry

* temporarily break extensions_build_config.bzl so we can see what the failure looks like

* Revert "temporarily break extensions_build_config.bzl so we can see what the failure looks like"

This reverts commit 2fbbc94.
# Matching actions
#

"envoy.matching.actions.format_string": "//source/extensions/matching/actions/format_string:config",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling this out. I commented out unused build options in extensions_build_config.bzl here: bc1b19f

@soloio-bulldozer soloio-bulldozer bot merged commit 206304f into release-v1.26 Dec 18, 2023
3 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the update-extensions-build-config-one-twenty-six branch December 18, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants