Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fork with more cpu #295

Closed
wants to merge 12 commits into from
Closed

Bump fork with more cpu #295

wants to merge 12 commits into from

Conversation

nfuden
Copy link
Collaborator

@nfuden nfuden commented Dec 4, 2023

No description provided.

@ben-taussig-solo
Copy link
Contributor

@nfuden
Copy link
Collaborator Author

nfuden commented Dec 4, 2023

@ben-taussig-solo
Copy link
Contributor

ben-taussig-solo commented Dec 4, 2023

Build failure here: https://storage.googleapis.com/solo-public-build-logs/logs.html?buildid=56070b95-1b86-4738-a9cc-53df21bbd9f0

ERROR: �[0m/workspace/test/extensions/filters/http/transformation/BUILD:61:19: Compiling test/extensions/filters/http/transformation/matcher_test.cc failed: (Killed): clang-14 failed: error executing command (from target //test/extensions/filters/http/transformation:matcher_test_lib_internal_only)

Step #1: Step #0 - "do_ci": �[32m[9,581 / 9,613]�[0m 20 / 28 tests;�[0m Compiling test/integration/transformation_filter_integration_test.cc; 900s linux-sandbox ... (2 actions running)
Step #1: Step #0 - "do_ci": �[32mINFO: �[0mElapsed time: 5543.716s, Critical Path: 988.29s
Step #1: Step #0 - "do_ci": �[32mINFO: �[0m9583 processes: 2876 internal, 6707 linux-sandbox.
Step #1: Step #0 - "do_ci": �[31m�[1mFAILED:�[0m Build did NOT complete successfully
Step #1: Step #0 - "do_ci": 
Step #1: Step #0 - "do_ci": Executed 20 out of 28 tests: 20 tests pass and �[0m�[35m8 were skipped�[0m.

so it looks like the job was killed due to this test timing out after compiling for 900s. also note that envoy built successfully, but that the job failed due to this test failing to build. I'm going to look into where it's set and whether it's possible to extend that 900s timeout

Update:

https://bazel.build/reference/test-encyclopedia#:~:text=Time%20Limit%20(sec.)&text=A%20%22large%22%20test%20with%20no,will%20be%20allotted%2060%20seconds.
A "large" test with no explicit timeout setting will be allotted 900 seconds to run. A "medium" test with a timeout of "short" will be allotted 60 seconds.

@ben-taussig-solo
Copy link
Contributor

/kick now that CI has passed on another PR with the same envoy-fork dependency

@nfuden nfuden closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants