Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix https://discord.com/channels/722131463138705510/910635844119982080/1280563749773639770 #1635

Merged
merged 4 commits into from
Sep 26, 2024
Merged

fix https://discord.com/channels/722131463138705510/910635844119982080/1280563749773639770 #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7dfee3
Update ErrorBoundary.tsx
russelgal Sep 26, 2024
5cbafd4
Update index.tsx
russelgal Sep 26, 2024
364b8d1
Update ErrorBoundary.tsx
russelgal Sep 26, 2024
d58f1e9
Create sixty-news-fly.md
ryansolid Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sixty-news-fly.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

fix dev overlay being pulled in even when not used
4 changes: 2 additions & 2 deletions packages/start/src/shared/ErrorBoundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// @refresh skip
import { ErrorBoundary as DefaultErrorBoundary, catchError, type ParentProps } from "solid-js";
import { ErrorBoundary as DefaultErrorBoundary, catchError, type ParentProps, lazy } from "solid-js";
import { isServer } from "solid-js/web";
import { HttpStatusCode } from "./HttpStatusCode";
import { DevOverlay } from "./dev-overlay";
const DevOverlay = lazy(() => import("./dev-overlay"));

export const ErrorBoundary =
import.meta.env.DEV && import.meta.env.START_DEV_OVERLAY
Expand Down
2 changes: 1 addition & 1 deletion packages/start/src/shared/dev-overlay/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const DevOverlayDialog =
}
: /* #__PURE__ */ clientOnly(() => import("./DevOverlayDialog"));

export function DevOverlay(props: DevOverlayProps): JSX.Element {
export default function DevOverlay(props: DevOverlayProps): JSX.Element {
const [errors, setErrors] = createSignal<unknown[]>([]);

function resetError() {
Expand Down