Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace fast-glob and glob with tinyglobby #1603

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

jlucaso1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

Using two dependencies to handle glob

What is the new behavior?

tinyglobby is meant to be a drop-in replacement to glob and fast-glob, and it only uses two subdependencies - fdir and picomatch. it's already being used in some somewhat big packages like vite-plugin-pwa and unocss with no user reports of breaking behavior.

Other information

Copy link

changeset-bot bot commented Aug 17, 2024

🦋 Changeset detected

Latest commit: 577f62d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid merged commit 45171b2 into solidjs:main Oct 18, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants