fix #1514 error header sanitization

solidjs · Jun 18, 2024 · ae6ca2e · ae6ca2e
1 parent 9da8b18
commit ae6ca2e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 11 deletions.
diff --git a/.changeset/curvy-ears-lay.md b/.changeset/curvy-ears-lay.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+fix #1514 error header sanitization
diff --git a/packages/start/src/runtime/server-handler.ts b/packages/start/src/runtime/server-handler.ts
@@ -2,16 +2,16 @@
 import { crossSerializeStream, fromJSON, getCrossReferenceHeader } from "seroval";
 // @ts-ignore
 import {
-	CustomEventPlugin,
-	DOMExceptionPlugin,
-	EventPlugin,
-	FormDataPlugin,
-	HeadersPlugin,
-	ReadableStreamPlugin,
-	RequestPlugin,
-	ResponsePlugin,
-	URLPlugin,
-	URLSearchParamsPlugin
+  CustomEventPlugin,
+  DOMExceptionPlugin,
+  EventPlugin,
+  FormDataPlugin,
+  HeadersPlugin,
+  ReadableStreamPlugin,
+  RequestPlugin,
+  ResponsePlugin,
+  URLPlugin,
+  URLSearchParamsPlugin
 } from "seroval-plugins/web";
 import { sharedConfig } from "solid-js";
 import { renderToString } from "solid-js/web";
@@ -202,7 +202,7 @@ async function handleServerFunction(h3Event: HTTPEvent) {
       setHeader(h3Event, "X-Error", "true");
     } else if (instance) {
       const error = x instanceof Error ? x.message : typeof x === "string" ? x : "true";
-      setHeader(h3Event, "X-Error", error);
+      setHeader(h3Event, "X-Error", error.replace(/[\r\n]+/g, ""));
     } else {
       x = handleNoJS(x, request, parsed, true);
     }