Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #42 Bug with Install Instructions / Requirements #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RyanJField
Copy link

@RyanJField RyanJField commented Aug 29, 2024

Fixes #42

Description

An issue was found with FRSM-13-R1-1, it was identified that when a nested data type was checked the key was not removed from the check key list, causing the loop to continue checking and having the potential to override the found key. Addionally it was found that on errors while decoding bytes to string was set to default ("strict") this may cause issues with non utf-8 parsable characters. Subsequently this was changed to "replace".

Additionally pyproject.toml was added to the dependencies as this can be a recognised python dependencies file (enhancing FRSM-13-R1-2). This might need to be validated.

Related issue: #42

Motivation and context

Fixes issue which prevents FRSM-13-R1-1/2 from passing

How has this been tested?

Tested using the swagger openAPI using the repo mentioned in the bug as well as repos which passed and failed this check including https://github.com/FAIRDataPipeline/pyDataPipeline

The test_evaluation.py tests and test_evaluation_software.yaml helper were updated to test these new changes.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@RyanJField RyanJField marked this pull request as ready for review August 30, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FRSM-13-R1 Not picking up install instructions or requirements
1 participant