Remove update_read_async method and use update_read instead
#924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of `update_read_async` caused stack overflows on Windows only, with exact details being quite a mystery. We did not really need a super performant async version of this code, as we are just using it to compute checksums of files residing in well known local filesystems, and thus the plain old `spawn_blocking` call should do as fine job as the removed code was expected to. Signed-off-by: Marek Kaput <[email protected]>
maciektr
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
update_read_asynccaused stack overflows on Windows only, with exact details being quite a mystery. We did not really need a super performant async version of this code, as we are just using it to compute checksums of files residing in well known local filesystems, and thus the plain oldspawn_blockingcall should do as fine job as the removed code was expected to.