Add CI to publish builtin plugins #1648
Conversation
DelevoXDG
changed the title
| name: Publish plugins | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| SCARB_REGISTRY_AUTH_TOKEN: ${{ secrets.SCARB_REGISTRY_AUTH_TOKEN }} |
There was a problem hiding this comment.
What token do you think we should keep in our GitHub secrets? Do we want to use some sort of an organization account, or will my personal token do for now? :D
Also, do you think we need any expiration date for it?
There was a problem hiding this comment.
Your personal will do. One year rotation seems alright.
| name: Publish plugins | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| SCARB_REGISTRY_AUTH_TOKEN: ${{ secrets.SCARB_REGISTRY_AUTH_TOKEN }} |
There was a problem hiding this comment.
Your personal will do. One year rotation seems alright.
| env: | ||
| SCARB_INIT_TEST_RUNNER: cairo-test | ||
|
|
||
| - name: Check if plugin versions exist in the registry |
There was a problem hiding this comment.
Why do we need to check it here? Can't we just try to publish and let the pipeline fail if it has already been uploaded? (Generally it expect it not to be, right?)
There was a problem hiding this comment.
(Generally it expect it not to be, right?)
Since some Cairo versions correspond to multiple Scarb versions, this is likely to happen from time to time.
Can't we just try to publish and let the pipeline fail if it has already been uploaded?
I think this is the question of deciding how do we want the action to resolve in such instances. We can continue-on-error, and let entire workflow fail, or we can skip the uploads. It seems to me that, if action is resolved with a result that is within what is expected, it should not be deemed "failed".
Test run: https://github.com/software-mansion/scarb/actions/runs/11365042651/job/31612347755?pr=1649
Closes #1619