Not sending variables if null (#19)

* Not sending variables if null
softonic · Aug 16, 2018 · d57e777 · d57e777
1 parent 50e4621
commit d57e777
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -20,19 +20,21 @@ public function __construct(ClientInterface $httpClient, ResponseBuilder $respon
      * @throws \UnexpectedValueException When response body is not a valid json
      * @throws \RuntimeException         When there are transfer errors
      */
-    public function query(string $query, array $variables = []): Response
+    public function query(string $query, array $variables = null): Response
     {
         $options = [
             'json' => [
                 'query' => $query,
-                'variables' => $variables,
             ],
         ];
+        if (!is_null($variables)) {
+            $options['json']['variables'] = $variables;
+        }
 
         try {
             $response = $this->httpClient->request('POST', '', $options);
         } catch (TransferException $e) {
-            throw new \RuntimeException('Network Error.'.$e->getMessage(), 0, $e);
+            throw new \RuntimeException('Network Error.' . $e->getMessage(), 0, $e);
         }
 
         return $this->responseBuilder->build($response);

diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -70,7 +70,6 @@ public function testSimpleQueryWhenInvalidJsonIsReceived()
                 [
                     'json' => [
                         'query' => $query,
-                        'variables' => [],
                     ],
                 ]
             )
@@ -109,7 +108,6 @@ public function testSimpleQuery()
                 [
                     'json' => [
                         'query' => $query,
-                        'variables' => [],
                     ],
                 ]
             )