Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spark_data_source.py with configuration param #1884

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Clusiv
Copy link

@Clusiv Clusiv commented Jun 5, 2023

Added param 'configuration' to support additional spark configurations like 'spark.executor.memory':'512m'

Added param 'configuration' to support additional spark configurations like 'spark.executor.memory':'512m'
@CLAassistant
Copy link

CLAassistant commented Jun 5, 2023

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.3% 14.3% Duplication

@@ -59,6 +60,7 @@ def hive_connection_function(
port=port,
database=database,
auth=auth_method,
configuration=configuration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use kwargs instead? Otherwise it will break other connection functions

Copy link
Contributor

@vijaykiran vijaykiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment about kwarts ...

@m1n0
Copy link
Contributor

m1n0 commented Nov 3, 2023

hi @Clusiv , could you please do the requested changes from above please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants