Merge pull request rails#50418 from the-spectator/buffered_checksum

Use buffered read while generating Blob checksum to improve memory
soartec-lab · Dec 26, 2023 · 5b62994 · 5b62994
2 parents 16ff9af + 92138c4
commit 5b62994
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/activestorage/app/models/active_storage/blob.rb b/activestorage/app/models/active_storage/blob.rb
@@ -350,8 +350,9 @@ def compute_checksum_in_chunks(io)
       raise ArgumentError, "io must be rewindable" unless io.respond_to?(:rewind)
 
       OpenSSL::Digest::MD5.new.tap do |checksum|
-        while chunk = io.read(5.megabytes)
-          checksum << chunk
+        read_buffer = "".b
+        while io.read(5.megabytes, read_buffer)
+          checksum << read_buffer
         end
 
         io.rewind