chore: enable Node 12 tests since CLI still supports it

snyk · Feb 21, 2023 · 7b99625 · 7b99625
1 parent 19c2f71
commit 7b99625
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 20 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -159,6 +159,26 @@ workflows:
  branches:
  ignore:
  - master
+ - test-windows:
+ name: Windows Tests for Node v12 support
+ context: nodejs-install
+ node_version: "12.22.12"
+ requires:
+ - Lint
+ filters:
+ branches:
+ ignore:
+ - master
+ - test-unix:
+ name: Unix Tests for Node v12 support
+ context: nodejs-install
+ node_version: "12.22.12"
+ requires:
+ - Lint
+ filters:
+ branches:
+ ignore:
+ - master
  - release:
  name: Release
  context: nodejs-app-release

diff --git a/lib/utils.ts b/lib/utils.ts
@@ -1,8 +1,5 @@
 import { readFileSync } from 'fs';
 import { InvalidUserInputError } from './errors';
-import * as baseDebug from 'debug';
-
-const debug = baseDebug('snyk-nodejs-parser');
 
 export enum NodeLockfileVersion {
  NpmLockV1 = 'NPM_LOCK_V1',
@@ -46,7 +43,6 @@ export function getNpmLockfileVersion(
  | NodeLockfileVersion.NpmLockV3 {
  try {
  const lockfileJson = JSON.parse(lockFileContents);
-
  const lockfileVersion: number | null = lockfileJson.lockfileVersion || null;
 
  switch (lockfileVersion) {
@@ -64,7 +60,6 @@ export function getNpmLockfileVersion(
  );
  }
  } catch (e) {
- debug('Failed to parse lockfile version: ', e);
  throw new InvalidUserInputError(
  `Problem parsing package-lock.json - make sure the package-lock.json is a valid JSON file`,
  );

diff --git a/test/fixtures/bare-npm/package-lock.json b/test/fixtures/bare-npm/package-lock.json
diff --git a/test/fixtures/bare-npm/package.json b/test/fixtures/bare-npm/package.json
@@ -1,13 +1,4 @@
 {
- "name": "Example",
- "version": "1.0.0",
- "lockfileVersion": 2,
- "requires": true,
- "packages": {
- "": {
- "name": "Example",
- "version": "1.0.0"
- }
- }
+ "name": "bare-npm",
+ "version": "1.0.0"
 }
-
diff --git a/test/jest/__snapshots__/get-lockfile-version.test.ts.snap b/test/jest/__snapshots__/get-lockfile-version.test.ts.snap
@@ -1,3 +1,3 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`getLockfileVersionFromFile npm 1`] = `"NPM_LOCK_V1"`;
+exports[`getLockfileVersionFromFile npm 1`] = `"NPM_LOCK_V2"`;