Experimental: Add option to select http4s backend #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `Content-Type` was not explicitly returned for POST requests. This would result in errors being logged for javascript tracker in Firefox[1]. Now, the behavior is rolled back to previous where collector would return `Content-Type` header for these requests. Addresses [BCPF-1102] and [PDP-1110] --- 1 - https://bugzilla.mozilla.org/show_bug.cgi?id=884693
peel
force-pushed
the
feature/configurable-http4s-backend
branch
5 times, most recently
from
be948dc
to
a9d8fa3
Compare
peel
added a commit
that referenced
this pull request
May 28, 2024
We've recently observed that blaze can have a very different behavioral semantics than ember. Where the latter might be desirable. For that reason it is useful to expose a setting allowing us to enable one or the other. This change adds `experimental` config section. This section is prone to backwards-incompatible change or removal.
peel
added a commit
that referenced
this pull request
May 28, 2024
Previously we supported blaze (default) and ember as http4s backends. This adds a new - pure Netty backend. Netty is a non-blocking I/O client-server framework for the network applications. There are some significant performance and feature differences. It provides a good control over request handling and underlying low-level protocol.
peel
added a commit
that referenced
this pull request
May 28, 2024
Previously we supported Blaze (default), Ember and Netty. This adds Ameria backend, that is based upon Netty under the hood. Ameria has some interesting features, especially GRPC support.
peel
force-pushed
the
feature/configurable-http4s-backend
branch
from
a9d8fa3
to
e9423d8
Compare
peel
added a commit
that referenced
this pull request
May 29, 2024
Previously we supported Blaze (default), Ember and Netty. This adds Ameria backend, that is based upon Netty under the hood. Ameria has some interesting features, especially GRPC support.
peel
force-pushed
the
feature/configurable-http4s-backend
branch
from
1de2ee4
to
900f5ff
Compare
peel
added a commit
that referenced
this pull request
May 29, 2024
Previously we supported Blaze (default), Ember and Netty. This adds Ameria backend, that is based upon Netty under the hood. Ameria has some interesting features, especially GRPC support.
peel
force-pushed
the
feature/configurable-http4s-backend
branch
from
900f5ff
to
5b144b4
Compare
peel
added a commit
that referenced
this pull request
May 29, 2024
Previously we supported Blaze (default), Ember and Netty. This adds Ameria backend, that is based upon Netty under the hood. Ameria has some interesting features, especially GRPC support.
peel
force-pushed
the
feature/configurable-http4s-backend
branch
from
5b144b4
to
8905c91
Compare
We've recently observed that blaze can have a very different behavioral semantics than ember. Where the latter might be desirable. For that reason it is useful to expose a setting allowing us to enable one or the other. This change adds `experimental` config section. This section is prone to backwards-incompatible change or removal.
Previously we supported blaze (default) and ember as http4s backends. This adds a new - pure Netty backend. Netty is a non-blocking I/O client-server framework for the network applications. There are some significant performance and feature differences. It provides a good control over request handling and underlying low-level protocol.
peel
force-pushed
the
feature/configurable-http4s-backend
branch
from
8905c91
to
b8f14b8
Compare
peel
added a commit
that referenced
this pull request
May 29, 2024
Previously we supported Blaze (default), Ember and Netty. This adds Ameria backend, that is based upon Netty under the hood. Ameria has some interesting features, especially GRPC support.
peel
force-pushed
the
feature/configurable-http4s-backend
branch
9 times, most recently
from
3098180
to
28450cf
Compare
peel
force-pushed
the
feature/configurable-http4s-backend
branch
4 times, most recently
from
6a7d2d6
to
b0594ff
Compare
istreeter
reviewed
Jun 3, 2024
core/src/main/scala/com.snowplowanalytics.snowplow.collector.core/HttpServer.scala
Outdated
Show resolved
Hide resolved
istreeter
approved these changes
Jun 3, 2024
Previously we supported Blaze (default), Ember and Netty. This adds Ameria backend, that is based upon Netty under the hood. Ameria has some interesting features, especially GRPC support.
Previously we had issues with enrich fatjars as we never really run them anywhere in practice. This is a problematic thing to maintain. This release removes fatjars as a distribution method.
peel
force-pushed
the
feature/configurable-http4s-backend
branch
from
6f22ddf
to
7f1b06a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently observed that blaze can have a very different behavioral semantics than ember. Where the latter might be desirable. For that reason it is useful to expose a setting allowing us to enable different backends according to runtime requirements. Currently supported backends: blaze (default), ember, netty, armeria.
This change adds
experimentalconfig section. This section is prone to backwards-incompatible change or removal.If we decide to keep the multiple-backend option, we probably want to reorganize how the backend is selected in
HttpService(makeHttpServicead-hoc polymorphic).Part of PDP-1217 PDP-1218 PDP-1219.