Make maxConnections and idleTimeout configurable #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peel
force-pushed
the
feature/networking-settings
branch
2 times, most recently
from
318739b
to
5e2abcd
Compare
benjben
approved these changes
Sep 20, 2023
http4s/src/main/scala/com.snowplowanalytics.snowplow.collector.core/HttpServer.scala
Outdated
Show resolved
Hide resolved
peel
force-pushed
the
feature/networking-settings
branch
2 times, most recently
from
b8991fa
to
2e644b3
Compare
spenes
force-pushed
the
feature/http4s
branch
from
c6982c8
to
b108007
Compare
peel
force-pushed
the
feature/networking-settings
branch
from
2e644b3
to
9fd1bda
Compare
Previously, idleTimeout has been hardcoded, maxConnections hasn't been configured. Now, these parameters are set within `networking` section and used throughout http4s backends.
peel
force-pushed
the
feature/networking-settings
branch
from
9fd1bda
to
fc41335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previusly, idleTimeout has been hardcoded, maxConnections hasn't been configured.
Now, these parameters are set within
networkingsection and used throughout http4s backends.