Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use Java properties to pass configuration in kinesis integrati… #343

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Don't use Java properties to pass configuration in kinesis integrati… #343

merged 1 commit into from
Sep 8, 2023

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Aug 25, 2023

…on tests

@pondzix pondzix force-pushed the http4s/kinesis_it_config_refactor branch 2 times, most recently from 81f7ae0 to 8965ccb Compare September 5, 2023 11:00
@pondzix pondzix force-pushed the http4s/kinesis_it_config_refactor branch from 8965ccb to b00c5bf Compare September 6, 2023 09:15
benjben
benjben approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@benjben benjben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...ala/com/snowplowanalytics/snowplow/collectors/scalastream/it/core/DoNotTrackCookieSpec.scala Show resolved Hide resolved
@pondzix pondzix merged commit b00c5bf into http4s/kinesis_sink_wrapper Sep 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjben benjben benjben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pondzix @benjben