Fix config loading #334
Merged
Fix config loading #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenes
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
I think this is okay but it would be good to get @istreeter's opinion as well since original design was his and there might be reason to use ConfigFactory.load in there.
istreeter
reviewed
Aug 18, 2023
| @@ -67,7 +67,7 @@ object ConfigParser { | |||
| } | |||
|
|
|||
| private def loadAll(config: TypesafeConfig): TypesafeConfig = | |||
| namespaced(ConfigFactory.load(namespaced(config.withFallback(namespaced(ConfigFactory.load()))))) | |||
| namespaced(config.withFallback(namespaced(ConfigFactory.load()))) | |||
There was a problem hiding this comment.
If you do it this way, then config precedence goes in this order:
- The config file
- System properties passed on the command line (e.g.
-Dcollector.port=8888) - Application defaults
It is more common to have this kind of precedence:
- System properties
- The config file
- Application defaults.
All of our other applications have the extra ConfigFactory.load so I would prefer to keep it if we can find a way.
There was a problem hiding this comment.
The reason for this change is that we observed that the config file was not overriding the default parameters. Do you know why ?
There was a problem hiding this comment.
Merged
pondzix
force-pushed
the
fix_config_parsing
branch
from
f7bef4e
to
bf461b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.