Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS support #330

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add CORS support #330

merged 1 commit into from
Aug 14, 2023

Conversation

spenes
Copy link
Contributor

@spenes spenes commented Aug 14, 2023

No description provided.

benjben
benjben reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@benjben benjben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions before I can approve the PR.

.../src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/CollectorService.scala Show resolved Hide resolved
.../src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/CollectorService.scala Outdated Show resolved Hide resolved
.../src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/CollectorService.scala Show resolved Hide resolved
.../src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/CollectorService.scala Show resolved Hide resolved
...c/test/scala/com.snowplowanalytics.snowplow.collectors.scalastream/CollectorRoutesSpec.scala Outdated Show resolved Hide resolved
...c/test/scala/com.snowplowanalytics.snowplow.collectors.scalastream/CollectorRoutesSpec.scala Show resolved Hide resolved
@spenes spenes requested a review from benjben August 14, 2023 10:41
benjben
benjben approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@benjben benjben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spenes !

@spenes spenes merged commit adf8035 into feature/http4s Aug 14, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjben benjben benjben approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spenes @benjben @snowplowcla