Skip to content

Commit

Permalink
Prepare for 2.9.0 release
Browse files Browse the repository at this point in the history
  • Loading branch information
@benjben
benjben committed Apr 11, 2023
1 parent 8c6f352 commit d9ee385
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions CHANGELOG
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,24 @@
Release 2.9.0 (2023-04-11)
--------------------------
Bump protobuf-java to 3.21.7 (#308)
PubSub: add second layer of retry (#304)
Replace set-output in Github Actions (#305)
Make MaxRetries configurable (#295)
Use sbt-snowplow-release to build docker images (#302)
Update /sink-health endpoint logic (#276)
Integration tests should work with both regular and distroless project (#301)
Scan Docker images with Snyk container monitor in deploy.yml (#296)
Add integration tests for Set-Cookie (#287)
Add integration test for doNotTrackCookie (#289)
Add integration test for X-Forwarded-For (#288)
Add integration test for custom paths (#286)
Add integration test for /health endpoint (#285)
Kinesis: add integration tests (#283)
Validate cookie.fallbackDomain config option on startup (#278)
PubSub: add integration tests (#274)
PubSub: make it possible to use PubSub emulator (#270)
Put MaxBytes in default application.conf instead of hard coding it (#272)

Release 2.8.2 (2022-11-03)
--------------------------
Ensure docker images have latest libexpat version (#268)
Expand Down

5 comments on commit d9ee385

@piankris
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have noticed that the path to the snowplow application has been changed in this relase (used to be ENTRYPOINT ["/opt/snowplow/bin/snowplow-stream-collector"] and now it's ENTRYPOINT ["/home/snowplow/bin/snowplow-stream-collector"]). It would be nice to have it explicitly included in the CHANGELOG to avoid confusion. We had problems in our pipeline before because of implicit path/folder structure changes because we have a complex setup where we need to load additional objects into the same directory as the snowplow app.

@benjben
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @piankris , may I ask what is your complex setup that prevents you from running the original Docker image that we publish ?

@piankris
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We load config files into the directory where the snowplow app is launched, so the path is critical here. The change in the path prevents the snowplow app from finding the configs then and thus to start.

@benjben
Copy link
Contributor Author

@benjben benjben commented on d9ee385 May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not mounting the config files with -v directly in your docker run command ? This way you wouldn't need to maintain your own image

@piankris
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use docker compose for all the snowplow modules. While some images can be used as they are, in others we have to do minor changes like substituting environment variables with sed commands because some modules don't have support for hocon configs. And of course, the shredder requires a little more work to set it up. Thus the necessity for custom images.

Please sign in to comment.