Return Content-Type for POST requests

Previously `Content-Type` was not explicitly returned for POST requests. This would result in errors being logged for javascript tracker in Firefox[1]. Now, the behavior is rolled back to previous where collector would return `Content-Type` header for these requests. Addresses [BCPF-1102] and [PDP-1110] --- 1 - https://bugzilla.mozilla.org/show_bug.cgi?id=884693
snowplow · Apr 10, 2024 · 59438a4 · 59438a4
1 parent df59504
commit 59438a4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/core/src/main/scala/com.snowplowanalytics.snowplow.collector.core/Service.scala b/core/src/main/scala/com.snowplowanalytics.snowplow.collector.core/Service.scala
@@ -261,7 +261,7 @@ class Service[F[_]: Sync](
       case _ =>
         Response[F](
           status  = Ok,
-          headers = headers,
+          headers = headers.put(`Content-Type`(MediaType.text.plain)),
           body    = Stream.emit("ok").through(fs2.text.utf8.encode)
         )
     }

diff --git a/core/src/test/scala/com.snowplowanalytics.snowplow.collector.core/ServiceSpec.scala b/core/src/test/scala/com.snowplowanalytics.snowplow.collector.core/ServiceSpec.scala
@@ -535,15 +535,16 @@ class ServiceSpec extends Specification {
         res.headers shouldEqual testHeaders
       }
       "send back ok otherwise" in {
+        val headers = testHeaders.put(`Content-Type`(MediaType.text.plain))
         val res = service.buildHttpResponse(
           queryParams   = Map.empty,
-          headers       = testHeaders,
+          headers       = headers,
           redirect      = false,
           pixelExpected = false,
           shouldBounce  = false
         )
         res.status shouldEqual Status.Ok
-        res.headers shouldEqual testHeaders
+        res.headers shouldEqual headers
         res.bodyText.compile.toList.unsafeRunSync() shouldEqual List("ok")
       }
     }
@@ -560,13 +561,14 @@ class ServiceSpec extends Specification {
         res.body.compile.toList.unsafeRunSync().toArray shouldEqual Service.pixel
       }
       "send back ok otherwise" in {
+        val headers = testHeaders.put(`Content-Type`(MediaType.text.plain))
         val res = service.buildUsualHttpResponse(
-          headers       = testHeaders,
+          headers       = headers,
           pixelExpected = false,
           shouldBounce  = false
         )
         res.status shouldEqual Status.Ok
-        res.headers shouldEqual testHeaders
+        res.headers shouldEqual headers
         res.bodyText.compile.toList.unsafeRunSync() shouldEqual List("ok")
       }
     }