-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add com.snowplowanalytics.iglu/client_error/jsonschema/1-0-0 #924
base: master
Are you sure you want to change the base?
Conversation
cddfe79
to
cdd9ce1
Compare
Hey @BenFradet (maybe @yalisassoon as well), could you please review this one? Couple of points:
|
cdd9ce1
to
f293bef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: did we do away with Validation error - schema was found, but data is invalid or the schema itself is invalid
from https://gist.github.com/chuwy/f03247b2c399d134d428aa81863bdfc4?
"version": "1-0-0" | ||
}, | ||
"type": "object", | ||
"required": ["error"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this relate to the anyOf
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, some error
is always present. Either ResolutionError
or ValidationError
"type": "string" | ||
}, | ||
"errors": { | ||
"type": "array", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a minItems
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good idea.
"minimum": 0 | ||
}, | ||
"fatal": { | ||
"type": "boolean" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we have a desc?
}, | ||
{ | ||
"description": "Data is invalid against its schema", | ||
"properties": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we seem to be missing required
and additionalProperties
"minItems": 1, | ||
"items": { | ||
"type": "object", | ||
"description": "List of reports", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just one report, no?
}, | ||
"targets": { | ||
"description": "List of properties affected in instance", | ||
"type": "array", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should there be a minItems
?
The schema is not used anywhere directly. But would be super-nice to have when we'll implement references. Descheduling. |
No description provided.