Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_succeeded/3-0-1 #1350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add load_succeeded/3-0-1 #1350

wants to merge 1 commit into from

Conversation

oguzhanunlu
Copy link
Member

No description provided.

@istreeter
Copy link
Contributor

Did you consider making this a 3-0-1 schema instead of 4-0-0? To do this, the schema would be basically the same, but you would make recoverTableNames a non-required field.

A major change is disruptive for downstream consumers of the data, because they need to consume from a different table. In this case, you have not radically re-designed the shape of the data; you have only added a new field. So I think downstream consumers would prefer to have new events land in the same table as the old events.

@oguzhanunlu oguzhanunlu changed the title Add load_succeeded/4-0-0 Add load_succeeded/3-0-1 Nov 6, 2023
@matus-tomlein matus-tomlein mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants