Update org.w3/PerformanceTiming SQL file #1323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
|
I signed the CLA! |
|
Confirmed! @TimmyCarbone has signed the Contributor License Agreement. Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The SQL file for the org.w3/PerformanceTiming/jsonschema/1-0-0 schema seems to be out of date (?).
This change adds the 5 missing columns (that are present in the schema) and re-orders the columns (like the latest versions of Snowplow would expect it?).
proxy_startproxy_endrequest_endunload_event_endunload_event_startThe SQL statement was generated using
igluctl 0.11.3against the org.w3/PerformanceTiming/jsonschema/1-0-0 schema in themasterbranch.