Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single table for events table #821

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

pkutaj
Copy link
Contributor

@pkutaj pkutaj commented Mar 29, 2024

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit 25bd1ee
🔍 Latest deploy log https://app.netlify.com/sites/snowplow-docs/deploys/66069f75a95ee600081b7170
😎 Deploy Preview https://deploy-preview-821--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jethron
Copy link
Contributor

jethron commented Apr 1, 2024

  • What's the order used here? I would expect it to match the enriched TSV order as defined in e.g. Redshift's atomic.events, an Analytics SDK, BQ Loader, etc.
  • (along these lines this is also missing etl_tags - which to be fair is useless - but is there)
  • ti_base_price seems to have some note attached that's now undefined
  • For this kind of reference I can imagine the field length limits being useful with a reference to validation.atomicFieldsLimits in case it becomes an issue; but I can appreciate that will be very annoying to add so definitely not a blocker by any means

@rlh1994
Copy link
Contributor

rlh1994 commented Apr 2, 2024

Is it worth solving this issue here as well #703

@rlh1994
Copy link
Contributor

rlh1994 commented Apr 2, 2024

Also might be worth making this a MUI table instead so it's nicely searchable and fits nicely etc. You can use src/components/MarkdownTableAsMui/index.js to keep it in markdown format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants