Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #1053

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update index.md #1053

wants to merge 2 commits into from

Conversation

danielyyy4
Copy link
Contributor

@danielyyy4 danielyyy4 commented Oct 25, 2024

Hi team - I would like to change the "Caution" section from "Caution" to "Info" or "Note" OR ca we remove the note that it is in public preview or is this necessary? @johnmicahreid

Hi team - I would like to change the "Caution" section from "Caution" to "Info" or "Note"
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit 0e2c3dd
🔍 Latest deploy log https://app.netlify.com/sites/snowplow-docs/deploys/6721fa424e675900087870f3
😎 Deploy Preview https://deploy-preview-1053--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johnmicahreid
Copy link
Contributor

This does not render correctly, I think we should just remove the public preview block entirely.
Screenshot 2024-10-29 at 17 00 34

@danielyyy4
Copy link
Contributor Author

I agree with removing @johnmicahreid

Copy link
Contributor

@johnmicahreid johnmicahreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @danielyyy4 note that the convention is the reviewer approves the change, and the contributor is responsible for actually merging the change / closing the PR.

@danielyyy4
Copy link
Contributor Author

I understand, @johnmicahreid. I currently do not have permissions to merge, but when Nick comes back I will ask him to add me to the Snowplow group so that I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants