-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.md #1045
base: main
Are you sure you want to change the base?
Update index.md #1045
Conversation
Updated the info section to make it more aligned to our new Packaging and Pricing. This was also a request I already review and got approval from Michele
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
✅ Deploy Preview for snowplow-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi team - Is this ready to be approved and merged? |
Confirmed! @danielyyy4 has signed the Contributor License Agreement. Thanks so much. |
@johnmicahreid could you help with this request please! |
@danielyyy4 just a note that you should add someone as a reviewer to ensure that your contributions get merged. At this level, the wording should be DBT packages, not DBT models, otherwise we will confuse our audience and make the product seem smaller than it is. A package contains multiple models, and we make efforts to ensure that we always talk about the Unified Digital DBT package / Media package etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, conditional on changing the wording to packages rather than models.
That makes sense, thanks for catching @johnmicahreid |
Updated the info section to make it more aligned to our new Packaging and Pricing. This was also a request I already review and got approval from Michele.