Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #1045

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update index.md #1045

wants to merge 2 commits into from

Conversation

danielyyy4
Copy link
Contributor

Updated the info section to make it more aligned to our new Packaging and Pricing. This was also a request I already review and got approval from Michele.

Updated the info section to make it more aligned to our new Packaging and Pricing. This was also a request I already review and got approval from Michele
@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for snowplow-docs ready!

Name Link
🔨 Latest commit a1ed7f2
🔍 Latest deploy log https://app.netlify.com/sites/snowplow-docs/deploys/6721f98deed1bd0008b8f479
😎 Deploy Preview https://deploy-preview-1045--snowplow-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielyyy4
Copy link
Contributor Author

Hi team - Is this ready to be approved and merged?

@snowplowcla
Copy link

Confirmed! @danielyyy4 has signed the Contributor License Agreement. Thanks so much.

@danielyyy4
Copy link
Contributor Author

@johnmicahreid could you help with this request please!

@johnmicahreid
Copy link
Contributor

@danielyyy4 just a note that you should add someone as a reviewer to ensure that your contributions get merged.

At this level, the wording should be DBT packages, not DBT models, otherwise we will confuse our audience and make the product seem smaller than it is. A package contains multiple models, and we make efforts to ensure that we always talk about the Unified Digital DBT package / Media package etc.

Copy link
Contributor

@johnmicahreid johnmicahreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, conditional on changing the wording to packages rather than models.

@danielyyy4
Copy link
Contributor Author

That makes sense, thanks for catching @johnmicahreid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants