Rework filter bots macro #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnessnowplow
force-pushed
the
feature/improve_filter_bots_PE6533
branch
3 times, most recently
from
6094cee
to
f35c131
Compare
ilias1111
reviewed
Oct 17, 2024
...ional_modules/core_web_vitals/scratch/default/snowplow_unified_web_vital_events_this_run.sql
Show resolved
Hide resolved
agnessnowplow
force-pushed
the
feature/improve_filter_bots_PE6533
branch
2 times, most recently
from
0d2d98c
to
16be271
Compare
agnessnowplow
force-pushed
the
feature/improve_filter_bots_PE6533
branch
from
16be271
to
f372b2f
Compare
ilias1111
approved these changes
Oct 18, 2024
agnessnowplow
merged commit 935f78f
into
Release/snowplow-unified/0.5.1
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sensible adjustments in the filter_bots() macro based on user request.
What type of PR is this? (check all applicable)
Related Tickets & Documents
https://snplow.atlassian.net/browse/PE-6533
Checklist
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?