Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/snowplow unified/0.4.4 #69

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Conversation

rlh1994
Copy link
Contributor

@rlh1994 rlh1994 commented Jun 26, 2024

Description

This PR adds early-release support for snowflake lake loader iceberg tables, and attempts to improve the performance of user_sessions_this_run

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

https://www.notion.so/keep-in-the-snow/Unified-c1215a5e3242469c9ad40192c363364d

Checklist

  • 💣 Is your change a breaking change?
  • 📖 I have updated the CHANGELOG.md

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📓 internal package docs (ymls, macros, readme, if applicable)
  • 📕 I have raised a Snowplow documentation PR if applicable (Link here)
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@rlh1994 rlh1994 requested a review from a team as a code owner June 26, 2024 09:09
Copy link

Release PR Checks Failed

rlh1994 and others added 4 commits June 26, 2024 10:20
* Add fail fast to let all warehouses run (purposeful fail)

* Undo purposeful break
* Make changes for snowflake lake loader support

* hard-cast fields

* reset project file

* lake loader isn't on by default

* Add note about lake loader workaround

* fix falses
@rlh1994 rlh1994 force-pushed the release/snowplow-unified/0.4.4 branch from 36803ee to 18b41dd Compare June 26, 2024 09:21
Copy link

Release PR Checks Failed

✅ Pass: Last commit message is prepare for release.
✅ Pass: First line of changelog is in the correct format.
✅ Pass: Changelog date (2024-06-26) is today (2024-06-26) or later.
❌ Error: Version in dbt_project.yml (0.4.4) does not match version in changelog (0.4.3).
❌ Error: Version in integration_tests/dbt_project.yml (0.4.4) does not match version in changelog (0.4.3).
❌ Error: New version (0.4.3) is not greater than the next newest version (0.4.3)

@rlh1994 rlh1994 force-pushed the release/snowplow-unified/0.4.4 branch from 18b41dd to d75ad25 Compare June 26, 2024 09:24
Copy link

Release PR Checks Passed

All checks passed successfully!

✅ Pass: Last commit message is prepare for release.
✅ Pass: First line of changelog is in the correct format.
✅ Pass: Changelog date (2024-06-26) is today (2024-06-26) or later.
✅ Pass: Version in dbt_project.yml (0.4.4) matches version in changelog (0.4.4).
✅ Pass: Version in integration_tests/dbt_project.yml (0.4.4) matches version in changelog (0.4.4).
✅ Pass: New version (0.4.4) is greater than the next newest version (0.4.3)

Copy link
Collaborator

@agnessnowplow agnessnowplow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlh1994 rlh1994 merged commit 503346d into main Jun 26, 2024
6 checks passed
@rlh1994 rlh1994 deleted the release/snowplow-unified/0.4.4 branch June 26, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants