charts/snowplow-iglu-server Remove post-upgrade hooks for aws and azure #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianarsenault
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Based on discussion, I don't know that we need this additional flag within the helm chart itself as we can configure service.aws.dev_db to deploy the hook job.
Are we ok to close this one out @antonis-snowplow ?
The previous changes have been removed from this PR, however we need to remove post-upgrade annotation for |
ianarsenault
reviewed
Nov 4, 2024
ianarsenault
changed the title
ianarsenault
changed the title
ianarsenault
changed the title
antonis-snowplow
deleted the
create-helm-hook-job-for-devdb-creatio-add-condition-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds condition to deploy hook job only when we use private subnet from previous PR #206
See #205