fix(button): fix click on mobile devices

snowball-tech · Oct 12, 2023 · 6c882dc · 6c882dc
1 parent b504339
commit 6c882dc
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/fractal/src/components/Button/Button.tsx b/packages/fractal/src/components/Button/Button.tsx
@@ -57,7 +57,11 @@ export const Button = forwardRef<HTMLButtonElement, ButtonProps>(
  props.onTouchEnd(event)
  }
 
- if ('ontouchstart' in document.documentElement) {
+ if (
+ 'ontouchstart' in document.documentElement &&
+ !isFunction(props.onTouchStart) &&
+ isFunction(onClick)
+ ) {
  event.preventDefault()
  }
  }
@@ -89,7 +93,10 @@ export const Button = forwardRef<HTMLButtonElement, ButtonProps>(
  onTouchStart={handleTouchStart}
  {...(isFunction(onClick) ? { onClick } : {})}
  title={label}
- {...omit(['className', 'dir', 'id'], props)}
+ {...omit(
+ ['className', 'dir', 'id', 'onTouchEnd', 'onTouchStart'],
+ props,
+ )}
  >
  {icon && iconPosition === 'left' ? (
  <div className={buttonIcon({ variant })}>{icon}</div>